On Fri, Mar 16, 2012 at 12:20 PM, John Yani <[email protected]> wrote: > On 16 March 2012 18:34, Ryosuke Niwa <[email protected]> wrote: >> If some reviewer and committer decide to use this process, where can I see >> review comments and other discussions? > > See point 3 of "Landing your code". Reviewer adds a link to pull > request in changelog.
If you're not familiar with GitHub, a pull request is something like a code review. Here's an example WebKit pull request that Eric and I did to experiment with the process: https://github.com/eseidel/webkit/pull/1 It's got all the usual code review features, including line-by-line comments: https://github.com/abarth/webkit/commit/d1ade93003a6c4d83a9ce3fda0d643785a171a8d Adam _______________________________________________ webkit-dev mailing list [email protected] http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
