On Mar 21, 2012, at 2:29 PM, Timothy Hatcher wrote: > Lately I have observed more and more and more changes going into WebKit that > lack any details about why a particular change was made. It is intended that > the ChangeLog (and commit message) contain some details about your change, > not just the bug title and URL. > > The contributing information on subject is pretty sparse, which has likely > caused this problem to manifest. However, the example ChangeLog linked from > that page is prime example of what we all should strive for when describing > our changes. > > To help curb this lack of detail in ChangeLogs, I propose we add script (or > augment an existing script) to check for this missing information and inform > the contributor. It is clear not all reviewers are asking patch authors to > provide this information when reviewing, and such a tool would help enforce > it.
I think this is a reasonable suggestion. I think we should make the contributor docs more clear about what is expected, as well. Regards, Maciej
_______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev