On Thu, Mar 22, 2012 at 10:38 AM, Eric Seidel <e...@webkit.org> wrote: > Thank you. Mark Rowe was kind enough to resolve > https://bugs.webkit.org/show_bug.cgi?id=81838#c8 in > http://trac.webkit.org/changeset/111634. > > I've found that some of the "Weak External Symbol" errors from > http://pastebin.com/dVjV8UiR can be resolved by marking the functions > in question as "inline", but that doesn't seem like the right fix. > > Some others like: > ERROR: symbol double WTF::strtod<(WTF::AllowTrailingJunkTag)0, > (WTF::AllowTrailingSpacesTag)0>(char const*, char**)
You may need GCC_SYMBOLS_PRIVATE_EXTERN = YES; on WTF.xcconfig. JavaScriptCore.xcconfig has it. > > Are for functions which are not even in headers: > http://trac.webkit.org/browser/trunk/Source/JavaScriptCore/wtf/dtoa.cpp#L651 > > So it's unclear what's causing those. > > Thank you for your attempts at documentation. Perhaps that will make > clear how these exports are supposed to work. :) > > -eric > > On Wed, Mar 21, 2012 at 6:21 PM, Hajime Morrita <morr...@google.com> wrote: >> I'll write a draft so that ports' expert can fill missing pieces. >> -- >> morrita >> >> On Thu, Mar 22, 2012 at 9:49 AM, Eric Seidel <e...@webkit.org> wrote: >>> Do we have any documentation for how the current symbol export system >>> for WTF/JSC is supposed to work? >>> >>> I'm hitting errors when trying to move WTF files to their own libwtf.a, >>> such as: >>> https://bugs.webkit.org/show_bug.cgi?id=81838 >>> and >>> http://pastebin.com/dVjV8UiR >>> >>> But looking at >>> http://trac.webkit.org/browser/trunk/Source/JavaScriptCore/wtf/ExportMacros.h >>> >>> It appears most of those macros are never used! (Like >>> WTF_EXPORT_CLASS, for example.) >>> >>> So when trying to resolve errors such as: >>> https://bugs.webkit.org/show_bug.cgi?id=81838#c8 >>> >>> The path is unclear. >>> >>> Perhaps there is a wiki somewhere on how this system is supposed to work? >>> >>> -eric >>> _______________________________________________ >>> webkit-dev mailing list >>> webkit-dev@lists.webkit.org >>> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev >> >> >> >> -- >> morrita _______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
