On Fri, Jun 8, 2012 at 12:46 AM, Osztrogonac Csaba <[email protected]>wrote:
> Hi, > > Dirk Pranke írta: > > I believe most if not all of the ports have started using either >> TestExpectations files or a combination of TestExpectations files >> (except for the Apple Win port). >> >> Can we explicitly switch to the TestExpectations files at this point >> and drop support for Skipped files on the other ports (and perhaps >> disable old-run-webkit-tests for all but apple win)? >> > > Until NRWT can't handle cascaded TestExpectations - > https://bugs.webkit.org/show_**bug.cgi?id=65834<https://bugs.webkit.org/show_bug.cgi?id=65834> > , > Qt port can't drop supporting Skipped files. We have many tests skipped in > qt-5.0, qt-5.0-wk1, > qt-5.0-wk2, wk2 Skipped lists. We can't migrate all of them to the only > one TestExpectations. > > And I disagree with disabling ORWT at all. Qt port still support using > ORWT locally. > It is better for gardening than NRWT. NRWT regularly has problems with > generating > new results for a given platform dir (qt,qt-5.0,qt-5.0-wk1,...), it > doesn't support > the good --skipped=only option . If folks don't want to use it, just not > use, but > disabling for everyone by fiat isn't a friendly thing. Can you file bugs for these explaining where it does something different from ORWT? Dirk is actively working on the cascading issue, but I don't think these other issues are known. I don't see why it would make sense to keep two parallel tools for this once all the workflow bugs people have are addressed. > If not, what needs to happen so that we can do that? Do we need to >> land more of the discussed changes to the syntax of the >> TestExpectations file? Anything else? >> >> It would be nice to get rid of the complexity (both in the code and in >> our heads) if we can. >> >> -- Dirk >> > > br, > Ossy > > ______________________________**_________________ > webkit-dev mailing list > [email protected] > http://lists.webkit.org/**mailman/listinfo.cgi/webkit-**dev<http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev> >
_______________________________________________ webkit-dev mailing list [email protected] http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
