12.06.2012, в 10:31, Ojan Vafai написал(а): > I'm sympathetic to this argument. In this case, the only way it makes the > tests more fragile is that it makes them depend on us firing the onload > event. I feel like so many things would break if you break onload, that it's > not really making the tests more fragile in practice.
There are always edge cases that are complicated. No longer than yesterday, I was helping someone with a test that mysteriously didn't print "Test Complete" in ToT WebKit, while that worked in Firefox. Unfortunately, I didn't capture the test back then, and cannot reproduce the problem right now (we ended up using a whole different approach in that test). Anyway, it's not difficult to think of cases where onload timing gets tricky. > Increasingly, js-test-pre.js is not being used by autogenerated code. This is > something we should encourage. I'm not sure what you mean by this. The make-new-script-test tool includes js-test-pre.js and js-test-post.js, and it's the only way to autogenerate the boilerplate that I'm aware of. - WBR, Alexey Proskuryakov
_______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
