I agree that the fuzzer should be used to create dedicated layout tests, but we shouldn't run the fuzzer itself as part of the layout test regression. I would have no objection to it being a separate test step.
-- Dirk On Tue, Jun 12, 2012 at 5:17 PM, Ojan Vafai <[email protected]> wrote: > See https://bugs.webkit.org/show_bug.cgi?id=87772. > > It's great to use a fuzzer in order to find cases where we're broken and > then make reduced layout tests from those. The viewspec-parser tests are > themselves just a fuzzer though. Granted, they are deterministic by avoiding > using an actual random function, but I don't think throwing randomly > generated bits at a parser is appropriate for layout testing. If nothing > else it's very slow. > > These tests regularly timeout on the Chromium debug bots and occasionally > timeout on the Apple Lion bots. Even on the bots where they don't timeout, > they're slow. I don't it makes sense to spend 1+ minutes running these 5 > tests when more targeted reductions could get the same effective coverage > much faster. > > Am I wrong? If not, does anyone object to moving these tests over to > ManualTests or just deleting them entirely? > > Ojan > > _______________________________________________ > webkit-dev mailing list > [email protected] > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev > _______________________________________________ webkit-dev mailing list [email protected] http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
