On Thu, Jun 14, 2012 at 1:44 PM, Peter Kasting <pkast...@chromium.org> wrote: > On Thu, Jun 14, 2012 at 1:39 PM, Elliot Poger <epo...@chromium.org> wrote: >> >> Can someone please remind me why IMAGE+TEXT even exists? >> >> Wouldn't it be simpler to just mark a test as follows? >> >> IMAGE : allow image failure; go red if there is a text failure >> TEXT: allow text failure; go red if there is an image failure >> IMAGE TEXT: allow text and/or image failure > > The distinction is that IMAGE TEXT will allow image, text, or both to fail, > thus making transitions among the three generate no events. IMAGE+TEXT says > specifically that we expect both to fail and that if one starts passing, > someone should do something. (For example, maybe someone checks in a > partial rebaseline where they miss the image expectations.) >
Also, unlike the now-deleted FAIL keyword, IMAGE TEXT indicates that the test is expected to be flaky. -- Dirk _______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
