Hi all, Using commit-queue doesn't pardon a committer from causing build failures.
Notice that the commit queue only builds & runs tests on Chromium Linux port. Thus, any build failure that doesn't manifest itself on Chromium Linux port — namely any JSC-specific or Windows/Mac specific build failures — won't be caught. The current policy specifically says the committer is responsible for making sure his or her patch builds & passes tests: http://www.webkit.org/coding/contributing.html So please make sure your patch at least builds if you're landing a patch via commit queue. Best, Ryosuke Niwa Software Engineer Google Inc.
_______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
