Please make sure the new text decoration values don't break editing (rich text editing & execCommand). In particular, we probably need to update ApplyStyleCommand/EditingStyle to handle -webkit-text-decoration*.
On Tue, Jul 31, 2012 at 7:35 PM, Bruno Abinader <brunoabina...@gmail.com>wrote: > Hi all :) > > As suggested by Ojan, I am writing a mail to you about my intention to > implement all updated and missing text-decoration* properties from > CSS3 spec (currently in development), named below: > > -webkit-text-decoration ( https://bugs.webkit.org/show_bug.cgi?id=92000 ) > CSS3 dev spec: http://dev.w3.org/csswg/css3-text/#text-decoration > Mozilla ref: https://developer.mozilla.org/en/CSS/text-decoration > Status: Proposed patch / pending review > > -webkit-text-decoration-line ( > https://bugs.webkit.org/show_bug.cgi?id=90959 ) > CSS3 dev spec: http://dev.w3.org/csswg/css3-text/#text-decoration-line > Mozilla ref: https://developer.mozilla.org/en/CSS/text-decoration-line > Status: Proposed patch / pending review > > -webkit-text-decoration-style ( > https://bugs.webkit.org/show_bug.cgi?id=90958 ) > CSS3 dev spec: http://dev.w3.org/csswg/css3-text/#text-decoration-style > Mozilla ref: https://developer.mozilla.org/en/CSS/text-decoration-style > Status: Proposed patch / pending review > > -webkit-text-decoration-color ( > https://bugs.webkit.org/show_bug.cgi?id=91638 ) > CSS3 dev spec: http://dev.w3.org/csswg/css3-text/#text-decoration-color > Mozilla ref: https://developer.mozilla.org/en/CSS/text-decoration-color > Status: Proposed patch / pending review > > -webkit-text-decoration-skip ( > https://bugs.webkit.org/show_bug.cgi?id=92801 ) > CSS3 dev spec: http://dev.w3.org/csswg/css3-text/#text-decoration-skip > Status: Work in progress > > As each patch touches similar places and sometimes requires previous > work, this patch series requires the patches to be reviewed / commited > in the same order as described above ( 92000, 90959, 90958, 91638 and > 92801 ). > The decision to use "-webkit-" prefix was suggested by Alexis on > https://bugs.webkit.org/show_bug.cgi?id=90959#c13 . There is also a > suggestion to use a specific flag to enable this feature at compile > time, however other CSS3 properties such as text-emphasis, for > example, do not use such flags, so I am a bit uncertain about it > still. > > I am really looking forward for comments and review on the proposed > patches :) > > Best regards, > > -- > Bruno de Oliveira Abinader > _______________________________________________ > webkit-dev mailing list > webkit-dev@lists.webkit.org > http://lists.webkit.org/mailman/listinfo/webkit-dev >
_______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
