On Jan 9, 2013, at 8:10 AM, Gustavo Noronha Silva <g...@gnome.org> wrote:
> On Qua, 2013-01-09 at 12:04 +0200, Thiago Marcos P. Santos wrote: >>> I think the fact that the regular WebKit review process stops at the >>> boundary >>> of WebKit2 should be documented in the WebKit Committers and Reviewer >>> Policy. >>> >> >> Agree. And please clarify on the policy if we are talking about >> everything inside the WebKit2/ directory or if we have exceptions. It >> is not clear to me if port specific code is covered by this rule and >> should by reviewed by the owners. And what about code shared by Qt, >> GTK and EFL (i.e. Platform/CoreIPC/unix/) but not used by Mac? > > Curious about this myself, I just reviewed a patch only affecting the > GTK-specific parts of WebKit2, I believe that is OK? Should we ammend > the Owners file to include information about port-specific directories > and reviewers? > > Cheers, At this point, we ask that all completely non-trivial patches be reviewed by an owner, even if in port specific code. - Sam _______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
