Hi,
2013/2/25 Adam Roben <aro...@webkit.org>: >> I was having a look at our Context Menu design when this USE flag got >> my attention. Can someone help me clarify the motivation for it? > > The motivation is explained pretty well in the ChangeLog for r73802, > which introduced this flag. I'll try to give a little explanation here > too. Yes, thanks for the explanation. I got mislead by another revision... Indeed it provides a good clean up for the ContextMenu code in WebCore so I have filled https://bugs.webkit.org/show_bug.cgi?id=111874. > >> Also, is there any other port using it? > > I don't believe so. But if you look at ContextMenu[Item].h, it looks > like CHROMIUM and EFL could very easily switch over to it; they've > already implemented something very similar by abusing the > PlatformMenuItemDescription typedef. Yes, I've already uploaded a patch for EFL. I will give it a try for Chromium as well. Cheers, jesus > > -Adam _______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
