How about creating an 'emeritus reviewer' status (no r+ power) and let people *voluntarily* move themselves to this status? I bet a lot of 'inactive reviewers' would do that, since everybody understands the issue of getting out of sync with current code base. It may have different vibe though than figuring some automatic time-based enforcement system...
As an added bonus, this gives such people a good way to avoid being asked to "review a patch for a colleague" while keeping some ties with the project... On Mon, Apr 8, 2013 at 3:34 PM, Maciej Stachowiak <m...@apple.com> wrote: > > On Apr 7, 2013, at 5:53 PM, Benjamin Poulain <benja...@webkit.org> wrote: > > On Sun, Apr 7, 2013 at 5:49 PM, Timothy Hatcher <timo...@apple.com> wrote: > >> I think 6 months is fine for deactivating SVN accounts. And a full revoke >> of reviewer status after 2 years of no activity sounds reasonable to me. We >> could make it easier to get reviewer status again after a 2 year sunset if >> the person becomes active again and shows good judgment still. >> > > +1 to this. > > I think 2 years to revoke reviewer rights is too long. All the drive-by > reviews that have caused problems were from reviewers that were inactive > for less than 2 years. Nevertheless, 2 years is better than the current > situation so it is a good start. > > > We sometimes get low-quality drive-by reviews even from people who are > active at the time. I feel like that's not the right basis for the time > cutoff. If we do have a sunset period, we should think about it in terms of > how long it takes to be so out of touch with the current state of the > project that there's little chance you can give a useful review. > > Regards, > Maciej > > > > _______________________________________________ > webkit-dev mailing list > webkit-dev@lists.webkit.org > https://lists.webkit.org/mailman/listinfo/webkit-dev > >
_______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
