Is there any special reason why MediaControlToggleClosedCaptionsButtonElement is created with type==button and not type==checkbox? (Source/WebCore/html/shadow/MediaControlElements.cpp:694)
I say that because its implementation uses setChecked(true/false) (MediaControlElements.cpp:716 and 704), which doesn't reflect on the behavior of the :checked selector for video::-webkit-media-controls-toggle-closed-captions-button defined on Source/WebCore/css/mediaControls[PORT].css, since that element is a button. For almost all the ports, the behavior of that component looks more like a checkbox (turning captions on/off). My question is: is it Ok to change the type of that object to "checkbox"? If we also change the defaultEventHandle (line 707) to capture the changeEvent instead of clickEvent, the behavior for all ports (including mac) shouldn't change. I think that all ports that uses it as a toggle will benefit from that, and it won't hurt apple's implementation. Proposal/draft here: https://bugs.webkit.org/show_bug.cgi?id=117177 -- Danilo Cesar Lemes de Paula _______________________________________________ webkit-dev mailing list [email protected] https://lists.webkit.org/mailman/listinfo/webkit-dev
