Hi,

Thanks for the heads-up. I'm not working on Qt port nowadays, but
some of my colleagues (azbest_hu, kadam and abrhm). I cc-ed them to
this thread.

I can confirm that Qt ARM didn't support NRWT long long time ago,
but the Qt ARM bot on http://build.webkit.sed.hu was switched to
use NRWT directly instead of this RWT wrapper script at least half
a year before. So it's safe to remove this useNewRunWebKitTests()
function. It won't break anything.

As far as I remember that Qt ARM has only an easily fixable NRWT
issue: http://wkb.ug/67777 . But it is unrelated to this bug.

I'm sure that the guys will fix these bugs quickly. ;)

Ossy

Ryosuke Niwa írta:
Hi,

It seems like the only port that uses ORWT by default is Qt ARM (and iOS) at this point.

Is it true that Qt ARM still doesn't support NRWT as this comment indicates?

sub useNewRunWebKitTests()
{
# NRWT does not support qt-arm: https://bugs.webkit.org/show_bug.cgi?id=64086
    return 0 if isQt() and isARM();
    # All other platforms should use NRWT by default.
    return 1;
}

If so, what are remaining issues? https://bugs.webkit.org/show_bug.cgi?id=64086 has already been fixed so we need a new bug to track it if we still have some issue on Qt ARM.

- R. Niwa
_______________________________________________
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Reply via email to