The problem here is Qt uses older compilers which do not detect when all cases are handled before the end of the function (like the example of Ryosuke).

It looks like this will not be a problem for much longer. Qt people are giving up on developing a web engine: http://blog.qt.digia.com/blog/2013/09/12/introducing-the-qt-webengine/

Benjamin

On 9/12/13 4:19 PM, Myles C. Maxfield wrote:
I can't speak for Qt, but this warning has been helpful for me in the past.


On Thu, Sep 12, 2013 at 2:07 PM, Ryosuke Niwa <rn...@webkit.org <mailto:rn...@webkit.org>> wrote:

    Hi,

    http://trac.webkit.org/changeset/155643 broke Qt build with an
    error saying:

    Source/JavaScriptCore/dfg/DFGGPRInfo.h:169:5: error: control
    reaches end of non-void function [-Werror=return-type]
    cc1plus: all warnings being treated as errors

    because of the following code:

    GPRReg gpr(WhichValueWord which) const
    {
        switch (which) {
        case TagWord:
            return tagGPR();
        case PayloadWord:
            return payloadGPR();
        }
    }

    But the code works just fine as is because WhichValueWord only
    takes two values (TagWord and PayloadWord) and they're all handled
    in the switch statement.

    Can we disable this warning so that we don't have to add a bogus
    code like the one I had to add in
    
http://trac.webkit.org/changeset/155649/trunk/Source/JavaScriptCore/dfg/DFGGPRInfo.h
    ?

    - R. Niwa


    _______________________________________________
    webkit-dev mailing list
    webkit-dev@lists.webkit.org <mailto:webkit-dev@lists.webkit.org>
    https://lists.webkit.org/mailman/listinfo/webkit-dev




_______________________________________________
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

_______________________________________________
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Reply via email to