My plan is to show style error when submitted patch doesn't use toFoo() though toFoo exists. This idea was originated from blink commit. However, it was reverted because of some regression.
http://src.chromium.org/viewvc/blink?view=revision&revision=158059 If my understanding is correct, the toFoo() style checker checks if there is toFoo() in a class. If uploaded patch uses static_cast<> instead of toFoo() though there is toFoo(), style checker will generate style error. Anyway, I think I need to investigate the commit and consider the idea further. Gyuyoung. On Tue, Oct 1, 2013 at 3:20 AM, Ryosuke Niwa <rn...@webkit.org> wrote: > On Mon, Sep 30, 2013 at 10:52 AM, Yong Li <yong.li.web...@outlook.com>wrote: > >> >> Bottom line is turning on RTTI in debug build? >> > > Style checker analyzes the code statically. It's nothing to do with > runtime assertions. If that wasn't clear enough, style check happens > before WebKit is ever built. > > - R. Niwa > > > _______________________________________________ > webkit-dev mailing list > webkit-dev@lists.webkit.org > https://lists.webkit.org/mailman/listinfo/webkit-dev > >
_______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
