Hi Gyuyoung, Then why is final/override working on EWS but not on the main build bots? Are they using different compiler flags?
According to wtf/Compiler.h, GCC should support override control since at least 4.7.0. Errors here: http://build.webkit.org/builders/EFL%20Linux%2032-bit%20Release%20%28Build%29/builds/22628/steps/compile-webkit/logs/stdio /mnt/buildbot/efl-linux-slave-3/efl-linux-32-release/build/Source/WebCore/editing/markup.cpp:142:60: error: expected ';' at end of member declaration /mnt/buildbot/efl-linux-slave-3/efl-linux-32-release/build/Source/WebCore/editing/markup.cpp:142:62: error: 'override' does not name a type /mnt/buildbot/efl-linux-slave-3/efl-linux-32-release/build/Source/WebCore/editing/markup.cpp:143:87: error: expected ';' at end of member declaration /mnt/buildbot/efl-linux-slave-3/efl-linux-32-release/build/Source/WebCore/editing/markup.cpp:143:89: error: 'override' does not name a type -Andreas On Oct 7, 2013, at 2:01 AM, Gyuyoung Kim <[email protected]> wrote: > Hi Andreas, > > > Are the main/EWS bots running different versions of GCC? > > No, EFL ews bots have same gcc version. EFL ews and buildbots are being ran > on two machines. As far as I know, those are based on Ubuntu 13.04 and have > same gcc 4.7.3. > > Thanks, > Gyuyoung. > > > On Mon, Oct 7, 2013 at 4:56 AM, Andreas Kling <[email protected]> wrote: > Hi folks, > > I recently landed a patch that makes use of lowercased “override” > and “final” in WebKit, and now the EFL build is failing. > > The EFL EWS bots didn’t have any problem with the patch however, > which brings me to my question: > > Are the main/EWS bots running different versions of GCC? > And if so, how soon can we make them use the same one? > > -Kling > _______________________________________________ > webkit-dev mailing list > [email protected] > https://lists.webkit.org/mailman/listinfo/webkit-dev > _______________________________________________ webkit-dev mailing list [email protected] https://lists.webkit.org/mailman/listinfo/webkit-dev
