Ryosuke and I discussed this a bit over IRC. Ryosuke's main concern was
that supporting multiple document roots adds a fair amount of complexity to
NRWT. Conceptually, it's probably easier to add support to run the W3C's
new server (known as wptserve) and then maybe use it for *all* imported
tests from the W3C.

If it turns out that wptserve is too slow, and you would prefer to run only
some of the directories over http (i.e., the 10k+ CSS tests don't need
http), you'll probably need to modify how wptserve is run (and NRWT) as
well, anyway, so the patch would be different.

Ryosuke, please let me know if I've misstated your thinking at all.

-- Dirk

On Mon, Jan 6, 2014 at 11:23 AM, Ryosuke Niwa <rn...@webkit.org> wrote:

> I don't think we should do this given that the python server has been
> added to W3C testing harness, and they're gonna convert all existing tests
> to use that instead:
> http://lists.w3.org/Archives/Public/public-test-infra/2014JanMar/0000.html
>
> We should simply wait for that effort to take place and add a support for
> the python server instead.
>
> - R. Niwa
>
>
> On Fri, Dec 6, 2013 at 12:25 AM, youenn fablet <youe...@gmail.com> wrote:
>
>> As long as the newly imported tests use relative URLs, alias may be used
>> as a workaround. I will give it a try.
>> Bug entry is at https://bugs.webkit.org/show_bug.cgi?id=125339
>> Any further help appreciated,
>>   Youenn
>>
>>
>>
>> 2013/12/6 Darin Adler <da...@apple.com>
>>
>>> If that's really ends up being super hard we can always put yet another
>>> third-party or imported directory inside the http directory as previously
>>> suggested. it's annoying to have three different places for imported tests
>>> and code, but not something I want to hold us up for a long time.
>>>
>>> -- Darin
>>>
>>> Sent from my iPhone
>>>
>>> On Dec 5, 2013, at 5:51 PM, Ryosuke Niwa <rn...@webkit.org> wrote:
>>>
>>> On Wed, Dec 4, 2013 at 11:19 AM, Darin Adler <da...@apple.com> wrote:
>>>
>>>> On Dec 4, 2013, at 6:48 AM, youenn fablet <youe...@gmail.com> wrote:
>>>>
>>>> I am planning to add some XHR tests from
>>>> https://github.com/w3c/web-platform-tests.
>>>> My initial plan was to add them in a subdirectory of
>>>> LayoutTests/http/tests/w3c.
>>>> If adding them into LayoutTests/imported/w3c, that would probably
>>>> require updating the test scripts to start/stop the HTTP test server
>>>> for that particular sub-folder.
>>>>
>>>> Any preference?
>>>>
>>>>
>>>> I’d prefer LayoutTests/imported/w3c. Although I’m not so happy about
>>>> the different terminology we are using for “imported” vs. “ThirdParty”,
>>>> which seems like the same concept at the top level of the directory
>>>> structure.
>>>>
>>>
>>> One trickiness to it is that we don't currently run any HTTP test in
>>> parallel and the document root of the HTTP server is set to
>>> LayoutTests/http/tests so we might need to modify that or restart the HTTP
>>> server whenever we're running HTTP tests outside of LayoutTests/http.
>>>
>>> - R. Niwa
>>>
>>>
>>
>
> _______________________________________________
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev
>
>
_______________________________________________
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Reply via email to