Hi Filip,
On 03/11/2014 06:43 PM, Filip Pizlo wrote:
On Mar 11, 2014, at 6:44 AM, Eva Balazsfalvi
<evab.u-sze...@partner.samsung.com
<mailto:evab.u-sze...@partner.samsung.com>> wrote:
Dear WebKit developers,
It's just a heads-up to let you know that rollout changelog format was
changed. The
previous format wasn't so informative, it wasn't obvious what was
rolled out and it
contained unnecessary informations - list of changed files and functions.
I've removed the list of changed files and functions and made the
changelog more
informative with showing the descriptions, bug urls and revision urls
of rolled out
patches in groups - http://trac.webkit.org/changeset/165447
Any particular reason for removing the list of changed files? I find
that to be the easiest way of determining, at a glance, what kind of an
effect a change has. If rollouts no longer include this list then I
will have to click the trac links for all of the reverted changes to
figure out that file list. Seems painful.
-Filip
https://bugs.webkit.org/show_bug.cgi?id=122654#c0 - by AP
"2. List of changed files and functions should be omitted - there are
never per-function comments in an automatically prepared rollout, and
searching ChangeLogs for function names doesn't need to show rollouts."
I don't understand you're problem, you still see the list of changed
files at a glance. Trac, webkit-changes mails, git log --name-status,
... still contain this list, only changelog and commit log don't.
If it is really painful for more developers, it's so easy to get
back this redundancy. You only need to revert this snippet (and
update the related webkitpy unit test results):
http://trac.webkit.org/changeset/165447/trunk/Tools/Scripts/webkitpy/common/checkout/changelog.py
Ossy
_______________________________________________
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev
