On Apr 17, 2014, at 5:45 AM, Benjamin Poulain <benja...@webkit.org> wrote:
> Hi Dirk, > > On 4/16/14, 1:18 PM, Dirk Schulze wrote: >> I would like to ask to remove the CANVAS_PATH compiler flag from WebCore >> where possible. At the moment it guards the Path2D object and all related >> methods in Canvas like: >> >> void fill(Path2D path, optional CanvasWindingRule winding); >> void stroke(Path2D path); >> void clip(Path2D path, optional CanvasWindingRule winding); >> >> Firefox and Chrome will ship with Path2D enabled in the next release >> versions. WebKits implementation is interoperable with Firefox and Chrome. >> >> The only method on Path2D that just reached consensus but does not ship in >> other browsers is addPath(Path2D, optional SVGMatrix?). The risk that it >> will change in an not interoperable way is minimal. >> However, at the moment I would like to guard it behind a compiler flag and >> implementations shouldn’t ship with it within the next couple of weeks. >> Alternatively, I can remove the IDL method in favor for removing the >> CANVAS_PATH compiler flag completely. > > I am in favor of keeping the flag around until the spec is stable (or Safari > ships the feature). The flag is used only in 4 files, its cost seems minimal. No objection for addPath. Path2D in general is stable enough and is shipping in Firefox and Chrome with the next releases. I would like to remove the flag around Path2D. Safari 7 ships with CANVAS_PATH enabled when the flag is removed around Path2D, it should not enable the flag for addPath() yet. Would you be ok with this suggestion? Greetings, Dirk > > Benjamin > _______________________________________________ > webkit-dev mailing list > webkit-dev@lists.webkit.org > https://lists.webkit.org/mailman/listinfo/webkit-dev _______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
