On Oct 16, 2014, at 4:04 PM, David Kilzer <ddkil...@webkit.org> wrote:
> On Oct 16, 2014, at 2:38 PM, David Kilzer <ddkil...@webkit.org> wrote: > >> Two commit queue issues: >> >> 1. Patches are landing, but bugs aren't being closed. Looks like >> webkit-patch is failing because a textarea is disabled by default. > > Bug 137794: commit-queue: fails to close bugs after successfully landing > patches > <https://bugs.webkit.org/show_bug.cgi?id=137794> > <http://trac.webkit.org/changeset/174797> > > Tentatively fixed. Still waiting for a cq+ patch to land with this fix > applied. (There are some in flight that will not have this fix yet.) > >> 2. Some commit queue patches fail to apply because 'OOPS!' is not being >> removed from ChangeLog entries. > > Bug 137795: commit-queue: fails to replace OO-PS! with reviewer name > <https://bugs.webkit.org/show_bug.cgi?id=137795> > > Investigating this now. Tentative fix (for the first issue found) checked in: <http://trac.webkit.org/changeset/174800> If neither of these work, please let me know. I'll check in later tonight to see how things are going. Dave > Dave > > >> Investigating. >> >> Dave >> -- >> Sent from my iPhone 6 >> >> On Oct 16, 2014, at 10:58 AM, David Kilzer <ddkil...@webkit.org> wrote: >> >>> Update complete. >>> >>> Please file bugs on bugs.webkit.org and reply to this thread with the bug. >>> >>> Thanks! >>> >>> Dave >>> -- >>> Sent from my iPhone 6 >>> >>> On Oct 16, 2014, at 10:56 AM, David Kilzer <ddkil...@webkit.org> wrote: >>> >>>> Sorry, sent this from the wrong address before the update. >>>> >>>>> On Oct 16, 2014, at 3:33 AM, Osztrogonác Csaba <o...@inf.u-szeged.hu> >>>>> wrote: >>>>> >>>>> Hi, >>>>> >>>>> have you tried if the webkit-patch bugzilla tool (upload, >>>>> apply-attachment, apply-from-bug, ... ), the review tool, >>>>> the commit queue and EWS will work properly with the new >>>>> bugzilla version? >>>> >>>> I did verify webkit-patch upload works. We don't have an easy way to test >>>> commit queue and EWS outside of the production environment. (That is >>>> something we want to improve going forward.) >>>> >>>> If those are too broken to fix quickly, the plan is to roll back. >>>> >>>>> I think they are very fragile and highly rely on the generated >>>>> HTML forms. I prefer fixing these tools before updating to >>>>> breaking them and then trying to fix. >>>> >>>> >>>> I wanted to upgrade as soon as possible to patch security issues that were >>>> not back-ported to the version we were running. >>>> >>>>> Just out of curiosity, if we do an upgrade, why do we upgrade >>>>> to the old stable release (4.2.11), why not the latest stable >>>>> relase (4.4.6)? Is there a fundamental reason for it? >>>> >>>> >>>> It was the quickest path to upgrade to a version where security patches >>>> were available. >>>> >>>> I had upgraded to 4.2.5 about a year ago, and had qualified over 90% of >>>> the website, so it was quickest to upgrade to 4.2.11 rather than 4.4.6 >>>> (which could have introduced more compat issues with tools). >>>> >>>>> There are many good fixes in 4.4 release. If we can't upgrade >>>>> to 4.4 for some reason, it would be great to cherry-pick at >>>>> least the following changes: >>>>> >>>>> "It is now possible to add yourself to the CC list when uploading an >>>>> attachment and when editing an existing one." (note) >>>>> --> auto cc reviewer - https://bugs.webkit.org/show_bug.cgi?id=124047 ) >>>>> >>>>> "Changes to the CC list no longer causes midair collisions." (note) >>>>> --> It is very annoying if you are commenting a bug, and you >>>>> have to start it again if somebody else cc-ed him/herself. >>>>> Or if you clicked force, it would remove these new cc-s. >>>> >>>> >>>> After we upgrade to 4.2.11, I will start work on 4.4.6 (plus a way to test >>>> the EWS and commit queue with our test environment). >>>> >>>>> And one more question: Are you planning to check-in >>>>> the new bugzilla to Websites/bugs.webkit.org ? >>>> >>>> >>>> Yes. That will be part of the upgrade. It's split into many individual >>>> patches (and 3 merge patches); I didn't want to squash-merge it in case it >>>> was easier to fix a future bug based on these changes. >>>> >>>> Dave >>>> >>>> >>>>> (note): http://www.bugzilla.org/releases/4.4/release-notes.html#v44_feat >>>>> >>>>> br, >>>>> Ossy >>>>> >>>>> David Kilzer írta: >>>>>> Hi, >>>>>> We’re planning on upgrading Bugzilla (bugs.webkit.org >>>>>> <http://bugs.webkit.org/>) from 3.2.3 to 4.2.11 on Thursday, October 16 >>>>>> from 8-10 AM PDT <x-apple-data-detectors://1>. >>>>>> Sorry for the short notice. I sent this message from the wrong address, >>>>>> and didn't see he bounce message until now. >>>>>> Please let me know if you have questions or concerns. Thanks! >>>>>> Dave >>>>> >>>> _______________________________________________ >>>> webkit-dev mailing list >>>> webkit-dev@lists.webkit.org >>>> https://lists.webkit.org/mailman/listinfo/webkit-dev >>> _______________________________________________ >>> webkit-dev mailing list >>> webkit-dev@lists.webkit.org >>> https://lists.webkit.org/mailman/listinfo/webkit-dev >> _______________________________________________ >> webkit-dev mailing list >> webkit-dev@lists.webkit.org >> https://lists.webkit.org/mailman/listinfo/webkit-dev > > _______________________________________________ > webkit-dev mailing list > webkit-dev@lists.webkit.org > https://lists.webkit.org/mailman/listinfo/webkit-dev
_______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
