Requiring a perf bot to be set up before removing unmaintained code seems like a really high bar. What would it take to do a one-shot test of whether NEON_INTRINSICS is a perf benefit? Would it show up on PLT or on JS perf benchmarks if you compiled with it? If it’s not a speedup in its existing form, then it’s probably not worth keeping around. If it is, then that might be incentive for someone to get it production-ready and on by default for relevant platforms.
Regards, Maciej > On Mar 8, 2015, at 6:56 PM, Benjamin Poulain <[email protected]> wrote: > > That code looks straightforward, the maintenance cost is likely low. We > just really need a test bot to run that code. > > I suggest we wait until we have a ARMv7 perf bot and re-evaluate > NEON_INTRINSICS. > > On 05/03/2015 22:27, Carlos Garcia Campos wrote: >> Yesterday a patch was submitted to fix the build with NEON_INTRINSICS, >> and Ossy pointed out that the build has been broken since r170433, and >> nobody has noticed it until now. So that makes me wonder if anybody is >> actually using that and if it even works, because otherwise we should >> probably remove the NEON_INTRINSICS code. >> >> So, is there anybody actually using that (I guess patched downstream)? >> >> >> _______________________________________________ >> webkit-dev mailing list >> [email protected] >> https://lists.webkit.org/mailman/listinfo/webkit-dev > > _______________________________________________ > webkit-dev mailing list > [email protected] > https://lists.webkit.org/mailman/listinfo/webkit-dev _______________________________________________ webkit-dev mailing list [email protected] https://lists.webkit.org/mailman/listinfo/webkit-dev
