Le 14/12/2015 à 19:39, Zalan Bujtas a écrit :
> It’s great to hear that MathML is getting some proper cleanup. I think the
> proposal sounds good and I am looking forward to the patches.
>
> Minor observation: I noticed that, since MathML block is no longer a flexbox,
> but it still needs some of the flexbox functionality, the following pattern
> has been introduced to the generic renderbox/block code.
> - if (parent()->isFlexibleBox()) {
> + if (parent()->isFlexibleBox() || parent()->isRenderMathMLBlock()) {
> I just wish there was another way to handle this.
>
> Zalan.
Hi Zalan,The final patch to move away from flexbox is now ready for review: https://bugs.webkit.org/show_bug.cgi?id=153991 A patch based on Alex's initial attempt is still available and as you can see we don't need to duplicate all of these RenderFlexibleBox functions any more. We still need some minor adjustments to make RenderMathMLBlock inherits from RenderBlock, though. In particular, regarding the 4 changes in RenderBox you mentioned we actually still need to keep two of them because MathML renderers shrink to fit their content instead of occupying the width of their container. Regards, Frédéric
signature.asc
Description: OpenPGP digital signature
_______________________________________________ webkit-dev mailing list [email protected] https://lists.webkit.org/mailman/listinfo/webkit-dev
