16.07.2016, 23:56, "Darin Adler" <da...@apple.com>: >> On Jul 16, 2016, at 10:21 AM, Konstantin Tokarev <annu...@yandex.ru> wrote: >> >> Yet another example: fast/layers/scroll-with-transform-composited-layer.html >> >> "All the boxes should only contain green content.” > > That one should be converted to a reference test. Note the comment inside the > test: > > <!-- This test should be a ref-test but small scrollbars difference > between platforms makes it fail. --> > >> Such tests would be harder to grep. > > To grep?
Sorry for inventing verbs :) I was using git grep to identify a list of tests which could be candidates for conversion into ref-test. However, now I see that this is not a useful thing to do, because there are both tests with large elaborated descriptions what should be painted, which cannot be reduced to pixel color check, and tests with no or almost no descriptions which nevertheless can also beconverted to ref-tests. So it's fine to take any random pixel / render tree dump test and try converting it into ref-test. There are many of such tests e.g. in fast. > > — Darin -- Regards, Konstantin _______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
