Patch was finalised by eric and already pushed to webkit.

On Fri, Dec 2, 2016 at 8:52 PM, Alexandre GOUAILLARD <agouaill...@gmail.com>
wrote:

> first patch uploaded for your kind review.
>
>
> On Thu, Dec 1, 2016 at 8:55 PM, Alexandre GOUAILLARD <
> agouaill...@gmail.com> wrote:
>
>> supposedly those two?
>>
>> https://trac.webkit.org/browser/trunk/Source/WebCore/Modules
>> /mediastream/NavigatorMediaDevices.idl
>> https://trac.webkit.org/browser/trunk/Source/WebCore/Modules
>> /mediastream/RTCPeerConnection.idl
>>
>> I opened a bug, https://bugs.webkit.org/show_bug.cgi?id=165251
>>
>> I'm waiting for a fresh clone, and I ll go ahead with a patch.
>>
>> Alex.
>>
>> On Thu, Dec 1, 2016 at 7:10 PM, youenn fablet <youe...@gmail.com> wrote:
>>
>>> It is good if we already have these runtime flags.
>>> Then we might just need to make the related IDLs exposed according that
>>> flag through EnabledAtRuntime keyword.
>>>   y
>>>
>>>
>>>
>>> Le jeu. 1 déc. 2016 à 11:55, Alexandre GOUAILLARD <agouaill...@gmail.com>
>>> a écrit :
>>>
>>>> Bonjour youenn,
>>>>
>>>> Eric avait fait ca en mars cette année. Tu peux regarder les commits
>>>> ci-dessous. J'ai vérifie hier, les flags de compil sont toujours a OFF, et
>>>> les runtimes sont aussi gardes. Je ne sais pas pourquoi les API sont
>>>> accessibles.
>>>>
>>>> https://bugs.webkit.org/show_bug.cgi?id=158393
>>>> https://trac.webkit.org/browser/trunk/Source/WebCore/binding
>>>> s/generic/RuntimeEnabledFeatures.h?rev=202704
>>>>
>>>> https://trac.webkit.org/changeset/198492
>>>>
>>>> Note that I documented those two flags on the webkit wiki on march 26
>>>> this year, after eric split the original MEDIA_STREAM into two:
>>>> https://trac.webkit.org/wiki/FeatureFlags
>>>>
>>>> Alex.
>>>>
>>>>
>>>> On Thu, Dec 1, 2016 at 6:48 PM, youenn fablet <youe...@gmail.com>
>>>> wrote:
>>>>
>>>> Hi Philipp,
>>>>
>>>> Thanks for bringing that up.
>>>> I think we should add runtime flags for getUserMedia and
>>>> RTCPeerConnection and set them to off in Safari Tech Preview until stable
>>>> enough.
>>>>
>>>>     y
>>>>
>>>>
>>>> Le mer. 30 nov. 2016 à 14:40, Philipp Hancke <fi...@appear.in> a
>>>> écrit :
>>>>
>>>> It has been brought to my attention that apparently Safari Tech Preview
>>>> Release 18 (Safari 10.1, WebKit 12603.1.12) is exposing RTCPeerConnection
>>>> and navigator.mediaDevices.getUserMedia.
>>>>
>>>> Since a check for
>>>>    navigator.mediaDevices.getUserMedia && window.RTCPeerConnection
>>>> and redirecting browsers that support neither is pretty common this is
>>>> rather unfortunate.
>>>>
>>>> The getUserMedia implementation does not seems to work on one of the
>>>> most basic GUM samples at
>>>>     https://webrtc.github.io/samples/src/content/getusermedia/gum/
>>>> I am actually not seeing GUM resolve or reject the promise at all.
>>>>
>>>> And RTCPeerConnection did not work either in
>>>>     https://webrtc.github.io/samples/src/content/peerconnection/pc1/
>>>>
>>>> What is the plan here?
>>>>
>>>> Philipp
>>>> _______________________________________________
>>>> webkit-dev mailing list
>>>> webkit-dev@lists.webkit.org
>>>> https://lists.webkit.org/mailman/listinfo/webkit-dev
>>>>
>>>>
>>>> _______________________________________________
>>>> webkit-dev mailing list
>>>> webkit-dev@lists.webkit.org
>>>> https://lists.webkit.org/mailman/listinfo/webkit-dev
>>>>
>>>>
>>>>
>>>>
>>>> --
>>>> Alex. Gouaillard, PhD, PhD, MBA
>>>> ------------------------------------------------------------
>>>> ------------------------
>>>> President - CoSMo Software Consulting, Singapore
>>>> ------------------------------------------------------------
>>>> ------------------------
>>>> sg.linkedin.com/agouaillard
>>>>
>>>>    -
>>>>
>>>>
>>
>>
>> --
>> Alex. Gouaillard, PhD, PhD, MBA
>> ------------------------------------------------------------
>> ------------------------
>> President - CoSMo Software Consulting, Singapore
>> ------------------------------------------------------------
>> ------------------------
>> sg.linkedin.com/agouaillard
>>
>>    -
>>
>>
>
>
> --
> Alex. Gouaillard, PhD, PhD, MBA
> ------------------------------------------------------------
> ------------------------
> President - CoSMo Software Consulting, Singapore
> ------------------------------------------------------------
> ------------------------
> sg.linkedin.com/agouaillard
>
>    -
>
>


-- 
Alex. Gouaillard, PhD, PhD, MBA
------------------------------------------------------------------------------------
President - CoSMo Software Consulting, Singapore
------------------------------------------------------------------------------------
sg.linkedin.com/agouaillard

   -
_______________________________________________
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Reply via email to