04.05.2017, 04:31, "Olmstead, Don" <don.olmst...@sony.com>: > I took some time today to see how clang-tidy can be run on WebKit code and > opened https://bugs.webkit.org/show_bug.cgi?id=171632 with some examples on > how to run things. I also attached some output from the modernizer fixes that > can be applied.
I think you should not mix different kinds of modernizations in the single patch. This way it would be easier to review the changes, also changes that are already used by community will get in fast as no-brainers, while others may need discussion. My 2c. > > I was thinking of running any code we move from WebCore/platform through > clang-tidy during the process of moving it to PAL. Documentation for the > checks can be found at > http://clang.llvm.org/extra/clang-tidy/checks/list.html if anyone wants to > take a look at what should potentially be run. > , > > _______________________________________________ > webkit-dev mailing list > webkit-dev@lists.webkit.org > https://lists.webkit.org/mailman/listinfo/webkit-dev -- Regards, Konstantin _______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
