On 05/05/17 00:24, Lucas Forschler wrote: > Hi Carlos! > > I recently updated the svn post commit hook to use the newest version of > svn_buildbot.py from > https://github.com/buildbot/buildbot-contrib/blob/master/master/contrib/svn_buildbot.py > > <https://github.com/buildbot/buildbot-contrib/blob/master/master/contrib/svn_buildbot.py> > > I am going to look through the diff now to see if there are any obvious > changes which would cause this. > Thanks for bringing it to our attention! > > Lucas
Its ok that the svn_buildbot script sends changes about any branches. But the buildbot config should only trigger branches for changes on trunk due to the change_filter": "trunk_filter" below: https://trac.webkit.org/browser/webkit/trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg?rev=216213#L954 https://trac.webkit.org/browser/trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json?rev=216213#L353 Maybe the issue is that the new svn_buildbot scripts fails to identify the branch name (for WebKitGTK+ we use a non-standard branch name: "releases") and sends the changes with branch "None"? Maybe the patch below fixes the issue? --- a/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg +++ b/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg @@ -951,7 +951,7 @@ class PlatformSpecificScheduler(AnyBranchScheduler): def filter(self, change): return wkbuild.should_build(self.platform, change.files) -trunk_filter = ChangeFilter(branch=["trunk", None]) +trunk_filter = ChangeFilter(branch="trunk") def loadBuilderConfig(c): # FIXME: These file handles are leaked.
signature.asc
Description: OpenPGP digital signature
_______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
