On Wed, Jun 27, 2018 at 8:05 PM Adam Barth <aba...@webkit.org> wrote:
>
> Hi Yusuke,
>
> For some reason, your original email missed my inbox.
>
> On Wed, Jun 27, 2018 at 7:53 PM Michael Catanzaro <mcatanz...@igalia.com> 
> wrote:
> > On Tue, Jun 26, 2018 at 6:49 PM, Yusuke SUZUKI <utatane....@gmail.com>
> > wrote:
> > > My suggestion is introducing Fushcia port, adding both
> > > PLATFORM(FUSHCIA) and OS(FUSHCIA) ifdefs.
> > > Use OS(FUSHCIA) when the change is b/c of Fushcia's APIs. And use
> > > PLATFORM(FUSHCIA) to change
> > > the policy of the released build (e.g. enabling / disabling FTL JIT
> > > etc.).
>
> So far, I seem to be able to control those features on a build level
> through CMake.
>
> > > By doing so, JSCOnly port also becomes available in Fushcia. And it
> > > means that Fushcia port can benefit
> > > from JSCOnly port's work for making WTF and JSC portable.
>
> Fuchsia appears to need to be a port in the sense of having an
> OptionsFuchsia.cmake in order to set the target triple to
> x86_64-unknown-fuchsia.  I didn't find any other uses of
> CMAKE_CXX_COMPILER_TARGET in WebKit.  Is there some other mechanism
> folks use to set the target triple (or maybe other folks aren't
> crosscompiling using clang)?

I discovered CMAKE_TOOLCHAIN_FILE and figured out how to make this work:

https://bugs.webkit.org/show_bug.cgi?id=187133

> > I wonder if PLATFORM(FUSHCIA) is even needed? Maybe OS(FUSHCIA) would
> > suffice? Then instead of a separate Fushcia port, we would just have
> > the existing JSCOnly port running on Fuschia.
>
> That sounds like a good approach to start with.  If we run into
> trouble, we might need to adjust.
>
> Adam
_______________________________________________
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Reply via email to