To confirm, this is what is expected? Is WebKit the root namespace?
namespace WebKit {
using namespace WebCore;
using namespace WebKit;
Thanks
> On Dec 7, 2018, at 8:45 AM, Chris Fleizach <cfleiz...@apple.com> wrote:
>
> Looks like there's quite a few of these. Will try to get them all
>
>> On Dec 7, 2018, at 8:37 AM, Tim Horton <timothy_hor...@apple.com
>> <mailto:timothy_hor...@apple.com>> wrote:
>>
>> Someone in UnifiedSource28-mm.mm is “using namespace WebCore” outside of the
>> root namespace.
>>
>>> On Dec 7, 2018, at 08:31, Chris Fleizach <cfleiz...@apple.com
>>> <mailto:cfleiz...@apple.com>> wrote:
>>>
>>> I'm hitting this tougher one now. Namespace conflict between Rect in Carbon
>>> and WebCore::Rect
>>>
>>> Any ideas?
>>> Thanks for your help
>>>
>>> n file included from
>>> /Volumes/Data/EWS/WebKit/WebKitBuild/Release/DerivedSources/WebKit2/unified-sources/UnifiedSource28-mm.mm:6:
>>> In file included from
>>> /Volumes/Data/EWS/WebKit/Source/WebKit/UIProcess/Plugins/mac/PluginInfoStoreMac.mm:32:
>>> In file included from
>>> /Volumes/Data/EWS/WebKit/Source/WebKit/Shared/Plugins/Netscape/NetscapePluginModule.h:34:
>>> In file included from
>>> /Volumes/Data/EWS/WebKit/WebKitBuild/Release/WebCore.framework/PrivateHeaders/npruntime_internal.h:28:
>>> In file included from
>>> /Volumes/Data/EWS/WebKit/WebKitBuild/Release/WebCore.framework/PrivateHeaders/npapi.h:82:
>>> In file included from
>>> /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk/System/Library/Frameworks/Carbon.framework/Headers/Carbon.h:29:
>>> In file included from
>>> /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk/System/Library/Frameworks/Carbon.framework/Frameworks/HIToolbox.framework/Headers/HIToolbox.h:35:
>>> In file included from
>>> /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk/System/Library/Frameworks/Carbon.framework/Frameworks/HIToolbox.framework/Headers/HIToolbar.h:26:
>>> In file included from
>>> /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk/System/Library/Frameworks/Carbon.framework/Frameworks/HIToolbox.framework/Headers/Menus.h:22:
>>> /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk/System/Library/Frameworks/Carbon.framework/Frameworks/HIToolbox.framework/Headers/Appearance.h:1373:3:
>>> error: reference to 'Rect' is ambiguous
>>> Rect bounds;
>>> ^
>>> In file included from
>>> /Volumes/Data/EWS/WebKit/WebKitBuild/Release/DerivedSources/WebKit2/unified-sources/UnifiedSource28-mm.mm:1:
>>> In file included from
>>> /Volumes/Data/EWS/WebKit/Source/WebKit/WebKit2Prefix.h:45:
>>> In file included from
>>> /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk/System/Library/Frameworks/CoreFoundation.framework/Headers/CoreFoundation.h:43:
>>> In file included from
>>> /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk/System/Library/Frameworks/CoreFoundation.framework/Headers/CFBase.h:77:
>>> /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk/usr/include/MacTypes.h:550:41:
>>> note: candidate found by name lookup is 'Rect'
>>> typedef struct Rect Rect;
>>> ^
>>> In file included from
>>> /Volumes/Data/EWS/WebKit/WebKitBuild/Release/DerivedSources/WebKit2/unified-sources/UnifiedSource28-mm.mm:1:
>>> In file included from
>>> /Volumes/Data/EWS/WebKit/Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm:95:
>>> /Volumes/Data/EWS/WebKit/WebKitBuild/Release/WebCore.framework/PrivateHeaders/Rect.h:60:7:
>>> note: candidate found by name lookup is 'WebCore::Rect'
>>> class Rect final : public RectBase, public RefCounted<Rect> {
>>> ^
>>>
>>>
>>>> On Dec 6, 2018, at 4:44 PM, Chris Fleizach <cfleiz...@apple.com
>>>> <mailto:cfleiz...@apple.com>> wrote:
>>>>
>>>> On it
>>>>
>>>>> On Dec 6, 2018, at 4:44 PM, Andy Estes <aes...@apple.com
>>>>> <mailto:aes...@apple.com>> wrote:
>>>>>
>>>>>
>>>>>
>>>>>> On Dec 6, 2018, at 4:37 PM, Chris Fleizach <cfleiz...@apple.com
>>>>>> <mailto:cfleiz...@apple.com>> wrote:
>>>>>>
>>>>>>
>>>>>>
>>>>>>> On Dec 6, 2018, at 4:37 PM, Ryan Haddad <ryanhad...@apple.com
>>>>>>> <mailto:ryanhad...@apple.com>> wrote:
>>>>>>>
>>>>>>> Chris,
>>>>>>>
>>>>>>> I'm assuming that this is in reference to the patch in
>>>>>>> https://bugs.webkit.org/show_bug.cgi?id=192373
>>>>>>> <https://bugs.webkit.org/show_bug.cgi?id=192373>. My guess is that
>>>>>>> something about the changes to
>>>>>>> Source/WebKit/WebKit.xcodeproj/project.pbxproj is causing an issue with
>>>>>>> unified sources.
>>>>>>>
>>>>>>> The commit-queue itself has been landing other patches without issue
>>>>>>> and the build isn't broken on trunk bots. CC'ing Tim in case he can
>>>>>>> help point out the issue.
>>>>>>>
>>>>>>
>>>>>> Yea must be. Any ideas why this wouldn’t build? I moved this .h/.mm to
>>>>>> another folder (from Mac -> Cocoa)
>>>>>
>>>>> Looks like we need to forward-declare class WebKit::SafeBrowsingWarning
>>>>> in WebViewImpl.h. Can you try that in your patch and see if that fixes it?
>>>>>
>>>>> Andy
>>>>
>>>> _______________________________________________
>>>> webkit-dev mailing list
>>>> webkit-dev@lists.webkit.org <mailto:webkit-dev@lists.webkit.org>
>>>> https://lists.webkit.org/mailman/listinfo/webkit-dev
>>>> <https://lists.webkit.org/mailman/listinfo/webkit-dev>
>>>
>
> _______________________________________________
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev
_______________________________________________
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev
