Hi Ross, > On Jan 15, 2019, at 11:50 AM, ross.kirsl...@sony.com wrote: > > Hi everybody, > > I’d like to verify whether there’s any specific reason that the > LayoutTests/sputnik directory continues to exist. > > According to Wikipedia, “All current Sputnik tests have been incorporated > into ECMA's Test262 test suite.” (Here “current” evidently means June 2011.) > And indeed, when making fixes to address Test262 failures in JSC, it’s quite > awkward to have to update the Sputnik expectations to reflect any new > “failures”—particularly given that it’s not sufficient to simply build JSC in > order to run them. I think it’s a good idea to remove these. (An aside: in general, I’m also not a fan of JS tests that don’t rely on the DOM existing in LayoutTests.)
> > Would anyone object to a patch deleting this directory outright? The only > concern that occurs to me is that Test262 is not currently integrated into > EWS. Maybe we should integrate these into EWS? The main downside is IIRC, these take a while to run. I think it’s ok to remove these even if we never add Test262 to EWS since we still run Test262 on bots post-commit. - Saam > > Thanks! > Ross > _______________________________________________ > webkit-dev mailing list > webkit-dev@lists.webkit.org <mailto:webkit-dev@lists.webkit.org> > https://lists.webkit.org/mailman/listinfo/webkit-dev > <https://lists.webkit.org/mailman/listinfo/webkit-dev>
_______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
