Seems like there is a consensus here. Here's a patch to codify it in our
code style guidelines: https://bugs.webkit.org/show_bug.cgi?id=204021
On Mon, Nov 4, 2019 at 8:06 AM Alex Christensen <achristen...@apple.com>
wrote:
> When the lambda is mutable or has a trailing return type, the () is
> currently required by the C++ grammar, so we can’t say to always omit ().
> We could say to always have it, to only have it when necessary, or have no
> code style guideline. I think we should always have spaces before and
> after, though.
>
> On Nov 3, 2019, at 3:27 AM, Ryosuke Niwa <rn...@webkit.org> wrote:
>
>
>
> On Sat, Nov 2, 2019 at 8:25 PM Ryosuke Niwa <rn...@webkit.org> wrote:
>
>>
>> On Sat, Nov 2, 2019 at 7:54 PM Chris Dumez <cdu...@apple.com> wrote:
>>
>>>
>>>
>>> On Nov 2, 2019, at 7:38 PM, Ryosuke Niwa <rn...@webkit.org> wrote:
>>>
>>>
>>>
>>> On Sat, Nov 2, 2019 at 1:23 AM Antti Koivisto <koivi...@iki.fi> wrote:
>>>
>>>>
>>>> On Sat, Nov 2, 2019 at 1:38 AM Ryosuke Niwa <rn...@webkit.org> wrote:
>>>>
>>>>> On Fri, Nov 1, 2019 at 11:53 AM Michael Catanzaro <
>>>>> mcatanz...@gnome.org> wrote:
>>>>>
>>>>>> On Fri, Nov 1, 2019 at 11:19 am, Ryosuke Niwa <rn...@webkit.org>
>>>>>> wrote:
>>>>>> > Namely, some people write a lambda as:
>>>>>> > auto x = [] () { }
>>>>>> >
>>>>>> > with a space between [] and () while others would write it as:
>>>>>> >
>>>>>> > auto x = []() { }
>>>>>>
>>>>>> 🔧: I omit the () when there are no parameters, as in these examples.
>>>>>>
>>>>>
>>>>> I guess that's another thing we should decide. Should we, or should we
>>>>> not have () when there are no arguments.
>>>>>
>>>>
>>>> I think this is easily settled by voting via exiting practice. We have
>>>> 1287 instances of [&] { and 107 instances of [&]() { and &] () { across the
>>>> whole WebKit.
>>>>
>>>
>>> That’s good to know. Why don’t we go with the status quo then.
>>>
>>> In this case, we do put a space between ] or ) and {, right?
>>>
>>>
>>> How is this the conclusion from Antti’s comment?
>>>
>>> Based on the discussion so far, it thought no space had a slight lead.
>>>
>>
>> I think you’re conflating this discussion with the other email thread
>> about a space between [] and ().
>>
>> Here, I’m talking about placing a space after [] before { as in:
>> [] { }
>>
>> As opposed to:
>> []{ }
>>
>> We never use the latter style whether it’s other control flow statements
>> like if, while, or for, or for function definitions.
>>
>> - R. Niwa
>>
>> --
>> - R. Niwa
>>
> --
> - R. Niwa
> _______________________________________________
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev
>
>
>
_______________________________________________
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev
