On 10/12/2019 17:52, Frédéric Wang wrote: > Hi everybody, > > Cathie has taken over my work on this. In order to facilitate review, > we decided to split the patch into three parts. If there is no > opposition, we'll probably go ahead and land (1) and (2) below. But in > any case, we need approval from Apple reviewers on (3). > > (1) Introduce CSS/IDL changes under a new preference flag > https://bugs.webkit.org/show_bug.cgi?id=205009 > > I already r+ed this part and I think Simon Fraser had reviewed > this part > before so I don't expect it to be controversial. The only question is > whether it makes sense to land this before the rest of the > implementation > is done. I guess it is ok to take it with (2) in any case. > > (2) Implement a generic animator class running in the scrolling > thread, based > on the one that already exists on GTK for smooth scrolling. > https://bugs.webkit.org/show_bug.cgi?id=204882 > > Simon has also partially reviewed this piece and modulo minor > changes I > think it looks good to me too. The issue here is that I'm not sure > I should > review it given I wrote most of this code. Also, it's probably not > the most > efficient approach and ports should probably rely on any existing > platform API to animate scrolling when available. However, it is a > necessary > fallback and the preference flag is turned off for now, so I think > it is > safe to take this for now... > > (3) Implement scroll animator in the UI process for iOS, based on native > platform support (UIScrollView). > https://bugs.webkit.org/show_bug.cgi?id=204936 > > This part hasn't been reviewed yet although the general design has > been > discussed with Simon. Alternatively, this patch can be taken > before (2) > since the two are more or less independent and each one really > only depends > on (1). > > I'm interested to hear about suggestions to rely on native scroll > animations for other ports. However, this can probably be done in > follow-up patches. Web developers really requested support on iOS and > it seems very important to have (3) for that port. > > Thank you,
Hi, As announced, parts (1) and (2) have landed and there does not seem to have been any issue in the past week. We'll go ahead with part (3). -- Frédéric Wang
_______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
