On Thu, 20 Aug 2020 at 6:26 Maciej Stachowiak <m...@apple.com> wrote:
> > > On Jul 17, 2020, at 12:12 AM, Noam Rosenthal <n...@webkit.org> wrote: > > > > On Thu, Jul 16, 2020 at 11:03 PM Keith Miller <keith_mil...@apple.com> > wrote: > >> Results appear to be neutral on the page load time benchmark, so you >> should be good on that front. I don’t know who the best person to vet the >> maturity of the code is though, sorry. >> > > Thanks a lot Keith, I appreciate it! > @Maciej Stachowiak <m...@apple.com>, what would be a good way to assert > whether the code maturity is good enough to enable paint timing by default? > The original code was reviewed by smfr and initially by zalan. It's > covered by over 30 tests, mostly WPT, and A/B tests show no effect on load > times as per Keith's check. > Would asking for additional reviews be the next step? From whom? > > > At this point, if a reviewer approves a patch to enable it by default on > trunk, I think you are good to go. > > As a courtesy to Apple, I’d ask you to hold off on landing until > mid-September, but that is optional. > Great The patch has already been reviewed, I will re-land it in mid September. Thank you! > > - Maciej >
_______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
