Hi Brian, Any way/option to turn off the unified build completely or partially in a local build? That would be very helpful for a developer to locally verify that header files are included correctly in a patch. Thanks!
Best regards Peng > On Nov 6, 2020, at 11:21 AM, Brian Burg via webkit-dev > <webkit-dev@lists.webkit.org> wrote: > > Hello folks, > > I'd like to remind everyone to please include what you use in .cpp, .mm, and > other files. When reviewing patches, please > ensure that new mentions of classes, structs, etc. within an implementation > file have a corresponding header include. > All of our headers have #pragma once, so there is no downside to being more > explicit. > > I've been noticing an uptick in the number of unified sources-related build > failures. I can't remember the last nontrivial patch > I wrote that did *not* include unrelated build fixes. Typically these > failures aren't found until EWS results come back, reducing developer > velocity. > And obviosuly it's super annoying to encounter completely unrelated build > failures that must be nonetheless addressed. > > Let's all do our part so that hacking on WebKit remains delightful. > > Thanks, > > Brian Burg (he/they) > WebKit Developer Experience > _______________________________________________ > webkit-dev mailing list > webkit-dev@lists.webkit.org > https://lists.webkit.org/mailman/listinfo/webkit-dev _______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
