> On May 11, 2022, at 11:56 AM, Jonathan Bedard via webkit-dev > <webkit-dev@lists.webkit.org> wrote: > > Trying to embed previous replies is going to get messy, will be referencing > those replies but not embedding them. > > Unsafe-Merge-Queue should be very fast, I haven’t seen anything take longer > than 10 minutes from label application to landing or rejection. The average > case is 3-4 minutes. We’re aware of what the architectural problem with > Commit-Queue is that slows down the fast path, Unsafe-Merge-Queue has fixed > that. The solution we used isn’t transferable to Commit-Queue.
I personally don’t think that delaying a critical build fix / gardening by 10 minutes is OK. It’s called “unsafe-merge-queue”, why does it take this long to commit? Why isn't it as fast as "generate a unique identifier and git push”? Sure, I have no idea how the unsafe-merge-queue does but it is hard for me to imagine it should take more than 1 minute given what it needs to do and given that it should need to do extremely little testing given that it is “unsafe”. 4 to 10 minutes is nowhere near as fast as `git svn dcommit` and is therefore a pretty large regression. _______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
