On Thu, Jun 2, 2022 at 4:28 AM Claudio Saavedra via webkit-dev <webkit-dev@lists.webkit.org> wrote: > > On Wed, 2022-06-01 at 16:39 -0700, Ryosuke Niwa via webkit-dev wrote: > > One day per month for one beginner sounds like a really low > > maintenance cost compared to having every WebKit developer fix non- > > unified builds at all times. > > I'm sorry, but this is not about having "every WK developer fix non- > unified builds at all times", it's about everyone making sure that > their patches are correct. A patch that uses API in one file without > making sure the required headers are included is not a correct patch > and unified builds are only hiding the issues. I don't see how this can > be controversial.
We probably disagree on what we mean by "correct". As far as I'm concerned, a patch is correct if all relevant ports can be built. There is theoretical correctness of cpp or headers files including all the necessary headers but that's merely theoretical outside of non-unified builds. I don't think we necessarily want to spend all our time thinking about & fixing theoretical problems until they actually surface. > Also, there is no pool of beginner developers who can be fixing missing > includes all the time; even if we had spare manpower, it's more > beneficial for the project (and themselves) if they spend that time > doing gardening or fixing actual bugs. Sorry, that was a typo / bad auto correction of the word "engineer". - R. Niwa _______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
