On 6/8/22 02:40, Elliott Williams via webkit-dev wrote: > >> On Jun 7, 2022, at 10:27, Olmstead, Don via webkit-dev >> <webkit-dev@lists.webkit.org> wrote: >> >> If we wanted to try any tooling around identifying when an include or >> forward declaration should be used we need a functioning non-unified build. >> We could try IWYU on the codebase, >> https://github.com/include-what-you-use/include-what-you-use , and see what >> happens. > I’ve been thinking about this, too. For Mac builds, we already have the > infrastructure to emit the compile database needed to run IWYU as a > post-build step. We could limit it to the files changed in a commit, which > ought to be very fast, and the verification would be higher-quality than a > non-unified builder since it’ll catch unused includes. In theory, we could > run it during local builds, too. > > But any meaningful integration would require figuring out how to build and > deploy it reliably, which seems annoying since it requires libclang, and > needs to be rebuilt whenever we change compilers.
This sounds great. Any solution that helps to solve or miminize the current issues related to unified builds has my support. -- Diego _______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
