Re: [webkit-dev] Newline translation issue with textareas

Mon, 20 Jun 2005 14:04:03 -0700

Alright, I'll do the translation in HTMLTextAreaElementImpl::setValue. And yes, it is a QString, although the QString is taken from a const DOMString, and those replace calls look like they replace-in-place. I'm not familiar with QString (or DOMString) yet, so is there any issue with calling these 2 lines on the QString returned by value.string() (where value is a const DOMString &)? Is that returning a value in the DOMString, or does the DOMString::string call copy its contents into a new QString?
I could probably figure this out by looking at the code, but I just thought it might be faster to ask. 

On Jun 20, 2005, at 4:55 PM, Darin Adler wrote:


Nah, I think it's OK to have the translation in two different  
places for now. If this was a QString, we'd be talking two lines of  
code here:


    xxx.replace("\r\n", '\n');
    xxx.replace('\r', '\n');

Lets not bend over too far backwards for this.


--
Kevin Ballard
[EMAIL PROTECTED]
http://www.tildesoft.com
http://kevin.sb.org




Attachment:
smime.p7s

Description: S/MIME cryptographic signature


_______________________________________________
webkit-dev mailing list
[email protected]
http://www.opendarwin.org/mailman/listinfo/webkit-dev






















					Reply via email to