On Sunday 04 December 2005 08:31, Eric Seidel wrote: > Hi all- > > I've been attempting to do some code cleanup in WebCore as of late. > I've removed several dead (and rotted) sections of #ifdef'd code, and > am about make patches to remove some more #ifdef'd sections and I > wanted to make sure there were no complaints. > > CACHE_DEBUG > PARSER_DEBUG > TOKEN_DEBUG > DEBUG_LAYOUT > FORMS_DEBUG > KJS_VERBOSE > CSS_DEBUG > CSS_STYLESHEET_DEBUG > > is the list of ifdefs (and associated code) which I plan to post > patches to remove. kdWarning, kdDebug, kdError are all noops in > WebCore, thus these #ifdefs are useless (without defining your own > local kdDebug, etc.) > > Any complaints? > > Any ifdefs which I haven't listed there which you'd like to make sure > we don't remove?
I object as well. This is just making it even harder to merge things with our tree, and we definitely use them. -- George Staikos KDE Developer http://www.kde.org/ Staikos Computing Services Inc. http://www.staikos.net/ _______________________________________________ webkit-dev mailing list [email protected] http://www.opendarwin.org/mailman/listinfo/webkit-dev
