On 28 Apr 2006, at 21:16, Maciej Stachowiak wrote:

Anyway, I have put my work on this at the end of the email, but I am not convinced it is worth changing to this without there being a noticeable benefit. I guess the multiple calls to hasLocalName don't have as much impact as we might think. Maybe if someone could test this on different hardware it might make a bigger difference.

Generally, we consider a repeatable 1-3% performance improvement to be worth it. And I think your change is a cleaner design anyway. I encourage you to put it up on bugzilla.

OK, but I'm not sure if I should provide a test case and if so, what it would test (and how)? (My patch runs all the current tests without any issues)

Matt



_______________________________________________
webkit-dev mailing list
[email protected]
http://www.opendarwin.org/mailman/listinfo/webkit-dev

Reply via email to