Re: [webkit-gtk] TextCodec.cpp lacks include when compiling with clang-7.0

[Denis Pronin]

Actually, including <cstdio> would do because it declares 'using std::snprinf' in global space. Moreover, there is a common recomendation to use c++ wrappers starting from <c...> over c-headers ending with <.h> in c++ code. I would rather you followed this recomendation to not break the rule

Thank you

16:21, 22 мая 2019 г., Michael Catanzaro <mcatanz...@igalia.com>:

On Tue, May 21, 2019 at 6:36 PM, Adrian Perez de Castro
<ape...@igalia.com> wrote:

 I just completed a build here with Clang 8.0 and it went just fine. I
 would
 like to know whether you were using libc++ instead of libstdc++
 before I try
 to install Clang 7.1.0 to see if I can reproduce the issue. Could you
 comment
 on that, please? (and thanks!)

If you fix this, remember it would be better to #include <stdio.h>
rather than #include <cstdio> because that file uses ::snprintf, not
std::snprintf.

--
Отправлено из мобильного приложения Яндекс.Почты

_______________________________________________
webkit-gtk mailing list
webkit-gtk@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-gtk