I'm OK with removing it. Kenneth
On Wed, Aug 4, 2010 at 5:32 AM, Simon Hausmann <[email protected]> wrote: > Hi, > > Jason just noticed the following snippet of code in QGraphicsWebView, that > appears to make it transparent by default: > > QWebPage* QGraphicsWebView::page() const > { > if (!d->page) { > QGraphicsWebView* that = const_cast<QGraphicsWebView*>(this); > QWebPage* page = new QWebPage(that); > > // Default to not having a background, in the case > // the page doesn't provide one. > QPalette palette = QApplication::palette(); > palette.setBrush(QPalette::Base, QColor::fromRgbF(0, 0, 0, 0)); > page->setPalette(palette); > > that->setPage(page); > } > > return d->page; > } > > Does anyone have any thoughts or objections against removing the default > transparent'ness of QGraphicsWebView? > > It appears inconsistent with QWebView and I would think that web content is > primarily designed for opaque backgrounds. > > > Simon > > _______________________________________________ > webkit-qt mailing list > [email protected] > http://lists.webkit.org/mailman/listinfo.cgi/webkit-qt > > -- Kenneth Rohde Christiansen Technical Lead / Senior Software Engineer Qt Labs Americas, Nokia Technology Institute, INdT Phone +55 81 8895 6002 / E-mail kenneth.christiansen at openbossa.org _______________________________________________ webkit-qt mailing list [email protected] http://lists.webkit.org/mailman/listinfo.cgi/webkit-qt
