Hey,

On 07/19/2011 04:48 AM, ext Lindsay Mathieson wrote:
Ok, I believe its ready for review - what do I do now? my git clone is here:

   https://gitorious.org/~blackpaw/webkit/webkit-qt-inline-spell

Note: I actually modified the QtTestBrowser project so it defined its
own static platform plugin implementation using sonnet from KDE for
testing purposes.

If you think it is ready, I suggest you squash the commits, make a changelog, and put that on WebKit's bugzilla for review.

You will get more attention from more reviewer that way.

Before uploading, you should take the opportunity to review you own code, and fix the coding style.


If you want an informal review beforehand for the style etc, feel free to squash the patches and send it to Dawit (I assume he is interested :)) and me.


cheers,
Benjamin
_______________________________________________
webkit-qt mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-qt

Reply via email to