Hi Milian, I think it would be much more likely that someone with insight to printing would look and review your patch if you would open a bugreport for the Tools/Tests component on http://webkit.org/new-qtwebkit-bug and upload a WIP patch there, since people usually do not download attachments and it much easier to review in bugzilla :)
See also: http://trac.webkit.org/wiki/QtWebKitContrib /Andras On 18 April 2012 13:55, Milian Wolff <[email protected]> wrote: > On Friday 13 April 2012 16:38:16 Milian Wolff wrote: >> On Wednesday 11 April 2012 20:05:39 Milian Wolff wrote: >> > Hey all, >> > >> > I'm interested in improving the printing support of the QtWebKit port. >> > >> > I notice that a lot of unit tests are skipped and that apparently >> > isPrinting() is not implemented/handled at all yet. >> > >> > For quite some time now I'm trying to figure out what exactly would be >> > required to get this done but it seems to be far from easy... Is there any >> > documentation besides the chromium spagetthi test code on how the output >> > should look like or when to output what (image, text, both, ...)? >> > >> > As far as I can see, I will probably have to handle the isPrinting() mode >> > in DumpRenderTreeQt.cpp ~ ::dump() in the if(m_dumpPixels) branch. >> > Currently, that only paints the viewportSize() to an image. If I'm not >> > mistaken, one needs to create a copy or QWebFrame::print, similar to >> > chromiums' >> > WebViewHost::paintPagesWithBoundaries. But what are the requirements on >> > the >> > output? Is there *any* documentation on what the tests should output? >> >> I've done this now, see the attached patch. It kind-of-works, e.g. for >> media- queries-print.html: http://imagebin.org/207870 >> >> But for setPrint.html I see horrible render bug which I do not the reason >> to: >> >> http://imagebin.org/207871 >> >> Note how the right border of the box is not properly drawn. Furthermore, the >> box is one pixel too high, or well - the bottom border is painted one pixel >> too far below. Compare to e.g. >> LayoutTests/platform/mac/printing/setPrinting- expected.png to see how it >> should look like. >> >> So... has anyone an idea of what could be going on here? > > *Bump* > > Could someone help me out here please? Or at least give me a review on the > patch? > > Cheers > -- > Milian Wolff | [email protected] | Software Engineer > KDAB (Deutschland) GmbH&Co KG, a KDAB Group company > Tel. Germany +49-30-521325470, Sweden (HQ) +46-563-540090 > KDAB - Qt Experts - Platform-independent software solutions > > _______________________________________________ > webkit-qt mailing list > [email protected] > http://lists.webkit.org/mailman/listinfo.cgi/webkit-qt > _______________________________________________ webkit-qt mailing list [email protected] http://lists.webkit.org/mailman/listinfo.cgi/webkit-qt
