04.05.2020, 07:13, "Ramakanth Kesireddy" <[email protected]>: > Thanks Konstantin for the quick response and fix. > > I shall apply the patch in the Qt webkit sources. Can you let me know if > these patches shall be part of > https://github.com/qtwebkit/qtwebkit/releases/tag/qtwebkit-5.212.0-alpha4?
They will be a part of next release > Also if I need to install the QtWebkit includes and libs in the > /usr/local/Qt-5.12.8, do I need to pass CMAKE_INSTALL_PREFIX = > /usr/local/Qt-5.12.8 in cmake -DPORT=Qt -DCMAKE_BUILD_TYPE=Release > -DQt5_DIR=/usr/local/Qt-5.12.8/lib/cmake/Qt5 -DENABLE_WEBKIT2=OFF > -DENABLE_OPENGL=OFF -DENABLE_GEOLOCATION=OFF -DENABLE_DEVICE_ORIENTATION=OFF > ../../qtwebkit or it installs by default? If your Qt prefix is /usr/local/Qt-5.12.8, it should be used by default, however you may want to check value of CMAKE_INSTALL_PREFIX in CMakeCache.txt (or with visual tool like ccmake or cmake-gui) > > Best Regards, > Ramakanth > > On Mon, May 4, 2020 at 9:25 AM Konstantin Tokarev <[email protected]> wrote: >> Patch https://0x0.st/i2Ls.txt should fix it >> >> 04.05.2020, 05:11, "Ramakanth Kesireddy" <[email protected]>: >>> Hi Konstantin, >>> >>> Thanks for your mail. >>> >>> I enabled -ssl in the configure line and rebuild Qtwebkit sources with >>> cmake. It passed the https support error. But it throws below error: >>> >>> Scanning dependencies of target QtTestBrowser_automoc >>> [ 98%] Automatic moc for target QtTestBrowser >>> Generating qttestbrowser.moc >>> Generating moc_cookiejar.cpp >>> Generating moc_fpstimer.cpp >>> Generating moc_launcherwindow.cpp >>> Generating moc_locationedit.cpp >>> Generating moc_mainwindow.cpp >>> Generating moc_urlloader.cpp >>> Generating moc_webinspector.cpp >>> Generating moc_webpage.cpp >>> Generating moc_webview.cpp >>> [ 98%] Built target QtTestBrowser_automoc >>> [ 98%] Generating qrc_QtTestBrowser.cpp >>> Scanning dependencies of target QtTestBrowser >>> [ 98%] Building CXX object >>> Tools/QtTestBrowser/CMakeFiles/QtTestBrowser.dir/cookiejar.cpp.o >>> [ 98%] Building CXX object >>> Tools/QtTestBrowser/CMakeFiles/QtTestBrowser.dir/fpstimer.cpp.o >>> [ 98%] Building CXX object >>> Tools/QtTestBrowser/CMakeFiles/QtTestBrowser.dir/launcherwindow.cpp.o >>> /home/ubuntu/qt-everywhere-src-5.12.8/qtwebkit/Tools/QtTestBrowser/launcherwindow.cpp: >>> In member function ‘void LauncherWindow::initializeView()’: >>> /home/ubuntu/qt-everywhere-src-5.12.8/qtwebkit/Tools/QtTestBrowser/launcherwindow.cpp:174:73: >>> error: ‘toggleQGLWidgetViewport’ was not declared in this scope >>> toggleQGLWidgetViewport(m_windowOptions.useQGLWidgetViewport); >>> ^ >>> Tools/QtTestBrowser/CMakeFiles/QtTestBrowser.dir/build.make:117: recipe for >>> target >>> 'Tools/QtTestBrowser/CMakeFiles/QtTestBrowser.dir/launcherwindow.cpp.o' >>> failed >>> make[2]: *** >>> [Tools/QtTestBrowser/CMakeFiles/QtTestBrowser.dir/launcherwindow.cpp.o] >>> Error 1 >>> CMakeFiles/Makefile2:2030: recipe for target >>> 'Tools/QtTestBrowser/CMakeFiles/QtTestBrowser.dir/all' failed >>> make[1]: *** [Tools/QtTestBrowser/CMakeFiles/QtTestBrowser.dir/all] Error 2 >>> Makefile:160: recipe for target 'all' failed >>> make: *** [all] Error 2 >>> >>> Please suggest in this regard. >>> >>> Best Regards, >>> Ramakanth >>> >>> On Mon, May 4, 2020 at 12:17 AM Konstantin Tokarev <[email protected]> >>> wrote: >>>> This error means that your Qt is configured without https support. I've >>>> made a patch that fixes compilation error, however it probably doesn't >>>> make much sense to use such configuration with QtWebKit. >>>> >>>> 01.05.2020, 16:52, "Ramakanth Kesireddy" <[email protected]>: >>>>> Hi , >>>>> >>>>> Thanks for your email.Finally I got cmake successful after building Qt >>>>> sensors and Qt positioning. >>>>> >>>>> However, make failed as below: >>>>> >>>>> /home/ubuntu/qt-everywhere-src-5.12.8/qtwebkit/Source/WebCore/platform/network/qt/CookieJarQt.cpp:129:49: >>>>> warning: unused parameter ‘session’ [-Wunused-parameter] >>>>> bool getRawCookies(const NetworkStorageSession& session, const URL& >>>>> /*firstParty*/, const URL& /*url*/, Vector<Cookie>& rawCookies) >>>>> ^ >>>>> [ 76%] Building CXX object >>>>> Source/WebCore/CMakeFiles/WebCore.dir/platform/network/qt/NetworkStateNotifierQt.cpp.o >>>>> [ 76%] Building CXX object >>>>> Source/WebCore/CMakeFiles/WebCore.dir/platform/network/qt/ProxyServerQt.cpp.o >>>>> [ 76%] Building CXX object >>>>> Source/WebCore/CMakeFiles/WebCore.dir/platform/network/qt/QNetworkReplyHandler.cpp.o >>>>> [ 76%] Building CXX object >>>>> Source/WebCore/CMakeFiles/WebCore.dir/platform/network/qt/QtMIMETypeSniffer.cpp.o >>>>> [ 76%] Building CXX object >>>>> Source/WebCore/CMakeFiles/WebCore.dir/platform/network/qt/ResourceHandleQt.cpp.o >>>>> [ 76%] Building CXX object >>>>> Source/WebCore/CMakeFiles/WebCore.dir/platform/network/qt/ResourceRequestQt.cpp.o >>>>> /home/ubuntu/qt-everywhere-src-5.12.8/qtwebkit/Source/WebCore/platform/network/qt/QtMIMETypeSniffer.cpp: >>>>> In member function ‘bool QtMIMETypeSniffer::sniff()’: >>>>> /home/ubuntu/qt-everywhere-src-5.12.8/qtwebkit/Source/WebCore/platform/network/qt/QtMIMETypeSniffer.cpp:51:55: >>>>> warning: comparison between signed and unsigned integer expressions >>>>> [-Wsign-compare] >>>>> if (!isReplyFinished && m_reply->bytesAvailable() < >>>>> m_sniffer.dataSize()) >>>>> ^ >>>>> /home/ubuntu/qt-everywhere-src-5.12.8/qtwebkit/Source/WebCore/platform/network/qt/QNetworkReplyHandler.cpp: >>>>> In member function ‘virtual qint64 >>>>> WebCore::FormDataIODevice::readData(char*, qint64)’: >>>>> /home/ubuntu/qt-everywhere-src-5.12.8/qtwebkit/Source/WebCore/platform/network/qt/QNetworkReplyHandler.cpp:198:32: >>>>> warning: comparison between signed and unsigned integer expressions >>>>> [-Wsign-compare] >>>>> if (m_currentDelta == element.m_data.size()) >>>>> ^ >>>>> [ 76%] Building CXX object >>>>> Source/WebCore/CMakeFiles/WebCore.dir/platform/network/qt/ResourceResponseQt.cpp.o >>>>> /home/ubuntu/qt-everywhere-src-5.12.8/qtwebkit/Source/WebCore/platform/network/qt/ResourceRequestQt.cpp: >>>>> In static member function ‘static bool >>>>> WebCore::ResourceRequest::alpnIsSupported()’: >>>>> /home/ubuntu/qt-everywhere-src-5.12.8/qtwebkit/Source/WebCore/platform/network/qt/ResourceRequestQt.cpp:68:12: >>>>> error: ‘QSslSocket’ has not been declared >>>>> return QSslSocket::sslLibraryVersionNumber() > 0x10002000L && >>>>> ^ >>>>> /home/ubuntu/qt-everywhere-src-5.12.8/qtwebkit/Source/WebCore/platform/network/qt/ResourceRequestQt.cpp:69:9: >>>>> error: ‘QSslSocket’ has not been declared >>>>> >>>>> QSslSocket::sslLibraryVersionString().startsWith(QLatin1String("OpenSSL")); >>>>> ^ >>>>> Source/WebCore/CMakeFiles/WebCore.dir/build.make:39113: recipe for target >>>>> 'Source/WebCore/CMakeFiles/WebCore.dir/platform/network/qt/ResourceRequestQt.cpp.o' >>>>> failed >>>>> make[2]: *** >>>>> [Source/WebCore/CMakeFiles/WebCore.dir/platform/network/qt/ResourceRequestQt.cpp.o] >>>>> Error 1 >>>>> make[2]: *** Waiting for unfinished jobs.... >>>>> CMakeFiles/Makefile2:1576: recipe for target >>>>> 'Source/WebCore/CMakeFiles/WebCore.dir/all' failed >>>>> make[1]: *** [Source/WebCore/CMakeFiles/WebCore.dir/all] Error 2 >>>>> Makefile:160: recipe for target 'all' failed >>>>> make: *** [all] Error 2 >>>>> >>>>> Here is the configure line with -no-openssl: >>>>> >>>>> ./configure -opensource -confirm-license -qt-libjpeg -qt-zlib -qt-libpng >>>>> -sql-sqlite -qt-xcb -no-cups -no-opengl -skip qt3d -skip qtactiveqt -skip >>>>> qtandroidextras -skip qtcanvas3d -skip qtcharts -skip qtconnectivity >>>>> -skip qtdatavis3d -skip qtdoc -skip qtdeclarative -skip qtgamepad -skip >>>>> qtgraphicaleffects -skip qtimageformats -skip qtnetworkauth -skip >>>>> qtmacextras -skip qtpurchasing -skip qtmultimedia -skip qtquickcontrols >>>>> -skip qtquickcontrols2 -skip qtremoteobjects -skip qtscript -skip qtscxml >>>>> -skip qtserialbus -skip qtserialport -skip qtspeech -skip qttools -skip >>>>> qtwayland -skip qtwebsockets -skip qtwebview -skip qtwebchannel -skip >>>>> qtwebengine -skip qtwinextras -skip qtandroidextras -skip qtx11extras >>>>> -skip qtxmlpatterns -nomake tools -nomake tests -nomake examples >>>>> -no-use-gold-linker -no-iconv -no-mtdev -dbus -fontconfig >>>>> -system-freetype -no-libudev -no-openssl -qt-pcre -v >>>>> >>>>> Could you please let me know if the error is because of Qt is not >>>>> configured with ssl though all dependencies and qt modules mentioned in >>>>> https://github.com/qtwebkit/qtwebkit/wiki/Building-QtWebKit-on-Linux >>>>> are installed or missing anything in this regard? >>>>> >>>>> Thanks and Regards, >>>>> Ramakanth >>>>> >>>>> On Fri, May 1, 2020 at 10:27 AM Ramakanth Kesireddy <[email protected]> >>>>> wrote: >>>>>> Looks like QtPositioning need to be installed as it throws below errors >>>>>> while running cmake with opengl and webkit2 disabled. >>>>>> >>>>>> -- Could NOT find Dwz (missing: DWZ_EXECUTABLE) (Required is at least >>>>>> version "0.13") >>>>>> -- Found WebP: /usr/include >>>>>> CMake Error at /usr/local/Qt-5.12.8/lib/cmake/Qt5/Qt5Config.cmake:28 >>>>>> (find_package): >>>>>> Could not find a package configuration file provided by >>>>>> "Qt5Positioning" >>>>>> with any of the following names: >>>>>> >>>>>> Qt5PositioningConfig.cmake >>>>>> qt5positioning-config.cmake >>>>>> >>>>>> Add the installation prefix of "Qt5Positioning" to CMAKE_PREFIX_PATH >>>>>> or set >>>>>> "Qt5Positioning_DIR" to a directory containing one of the above files. >>>>>> If >>>>>> "Qt5Positioning" provides a separate development package or SDK, be >>>>>> sure it >>>>>> has been installed. >>>>>> Call Stack (most recent call first): >>>>>> Source/cmake/OptionsQt.cmake:646 (find_package) >>>>>> Source/cmake/WebKitCommon.cmake:51 (include) >>>>>> CMakeLists.txt:137 (include) >>>>>> >>>>>> Best Regards, >>>>>> Ramakanth >>>>>> >>>>>> On Fri, May 1, 2020 at 9:29 AM Ramakanth Kesireddy <[email protected]> >>>>>> wrote: >>>>>>> Hi Konstantin, >>>>>>> >>>>>>> Thanks for your mail. >>>>>>> >>>>>>> As per >>>>>>> https://github.com/qtwebkit/qtwebkit/wiki/Building-QtWebKit-on-Linux, >>>>>>> it has dependency on Qt positioning and sensor modules. >>>>>>> Since in the configure line, I skipped the modules using -skip >>>>>>> qtlocation -skip qtsensors, Could you please let me know if Qtwebkit >>>>>>> has mandatory dependency on these modules or can be disabled with >>>>>>> -DENABLE_LOCATION=OFF and >>>>>>> -DENABLE_SENSORS=OFF ? >>>>>>> >>>>>>> Best Regards, >>>>>>> Ramakanth >>>>>>> >>>>>>> On Thu, Apr 30, 2020 at 10:43 PM Konstantin Tokarev <[email protected]> >>>>>>> wrote: >>>>>>>> 30.04.2020, 19:29, "Ramakanth Kesireddy" <[email protected]>: >>>>>>>>> I need to pass below options in the cmake configure options,right? >>>>>>>> >>>>>>>> Yes >>>>>>>> >>>>>>>>> >>>>>>>>> So QtWebkit cannot be build along with Qt 5.12.8 sources unlike with >>>>>>>>> Qt 5.6.3 earlier as the build is being supported only with cmake and >>>>>>>>> needs to be built with cmake on Qt installed binaries? >>>>>>>> >>>>>>>> Yes >>>>>>>> >>>>>>>> -- >>>>>>>> Regards, >>>>>>>> Konstantin >>>> >>>> -- >>>> Regards, >>>> Konstantin >> >> -- >> Regards, >> Konstantin -- Regards, Konstantin _______________________________________________ webkit-qt mailing list [email protected] https://lists.webkit.org/mailman/listinfo/webkit-qt
