Jan Rychter <[email protected]> writes: > Ok, I have the first cut of the new nav design, it works for my > application so far. Dynamic wiki-style on-demand navigation is untested. > > It turns out Stephen was right being suspicious about the dispatcher > (Stephen, thanks for your comments!). In my design the dispatcher is > gone, so is selector-mixin. A rough diagram of what things look like is > here: > http://screech.rychter.com/files/weblocks-new-nav-design-20081214-2.pdf
I really like this. Some points: * I don't think it should subclass `container'. See how I've stripped down `container.lisp' in [1]. Container seems to be becoming a type-tag (as it is for selector), leading webapp authors down the path of indiscriminately spraying it on their widget trees; this is part of my motivation for removing CUC/CUDC in favor of widget tree walking. * I'm not great at naming, but shouldn't the name of `selector' reflect that it is related to URI parsing? If `selector' communicates this effectively, ignore this point. * Assuming CUC and CUDC are abandoned as I suggest in [1], and replaced with the walk-widgets/update-uri-tokens semantics implemented there, it ought to be specified that all you need to have a selector widget is to implement get-widget-for-tokens and update-uri-tokens for your widget class, and subclassing selector is unnecessary (although convenient, as selector has a reasonable update-uri-tokens implementation). * Question: Is a selector required to render its selected widget? > 4. Go back to step 1. The nice thing about this is that git notices the > changesets that were cherry-picked into another branch and just silently > reorders things. I don't get conflicts or even warnings about duplicate > changesets. This is beautiful. I am very much against changing VCS again. ยน http://bitbucket.org/S11001001/weblocks-modern-dispatching/ -- I write stuff at http://failex.blogspot.com/ now. But the post formatter and themes are terrible for sharing code, the primary content, so it might go away sooner or later. --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "weblocks" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/weblocks?hl=en -~----------~----~----~----~------~----~------~--~---
