Jan Rychter <[email protected]> writes: > "Leslie P. Polzer" <[email protected]> writes: > [...] >>> Is there agreement on navigation-rewrite EXCEPT >>> set/get-children-of-type? If so, then perhaps you can start your work >>> basing it on navigation-rewrite? >> >> I will work directly on weblocks-jwr/navigation-rewrite. >> I hope to get it merged by this or next week. >> Lots of fun with the test suite waiting for me... > > My dirty conscience got the better of me, so I'll at least provide you > with a navigation-rewrite merged into the latest -dev, later today.
The merge is in a new branch: http://github.com/jwr/weblocks-jwr/tree/navigation-rewrite-merge-with-dev-cd83809dfadc I verified that it compiles, but that's pretty much it. It probably doesn't work. Here are notes that I made while merging: render-menu in menu.lisp: Instead of disabled-pane-names we now have disabled-panes. It is now a list of uri-tokens corresponding to the disabled menu items, e.g. we key on the token instead of on the attributized name, in sync with other parameters to render-menu. Keying on the token is in general more reliable and predictable. Passing functions as cdrs of pane cons cells will probably not work, as the 'target' is compared using equalp to strings. This needs to be reworked -- I'm leaving it as-is for now. navigation.lisp: I renamed disabled-pane-names to disabled-panes, to bring it in line with the rest of the navigation stuff, which means it now stores a list of uri-tokens, not a list of attributized names. table-composite.lisp: table-composite got inadvertently killed, because there is no composite anymore. This could be reimplemented as a simple widget, as most of what composite did is now in widget. template-block.lisp: couldn't get asdf-system-connections to work -- I don't even get the required symbol on *features*, and then it complains about how it can't get the truename of the template-block.lisp file. I don't have time to debug this right now, so I just loaded html-template and template-block.lisp manually. Perhaps those who brought in asdf-system-connections can take a look at this, or perhaps it works for everyone but me. There are two changesets on top of the merge, which are really "oops" fixes. I hope this helps. --J. --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "weblocks" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/weblocks?hl=en -~----------~----~----~----~------~----~------~--~---
