On Apr 9, 2:57 pm, Andrea Russo <[email protected]> wrote:

> Starting from Marco's patch, I wrote this new patch with which I'm
> reasonably happy.
>
> What do you think about it? (please recall that I'm a Common Lisp newbie
> :-)

It's pretty good for that, actually.

Some changes that need to be made:

  * you forgot to export *default-restart*

  * the documentation for *default-restart* should be a docstring
instead of a code comment

  * I think we still need *catch-errors-p* to be able to pass on
handling of a signal outside of the Weblocks handler (for example in
the test case `allow-restart-in-sessinit')

  * the indentation level in handle-client-request is too much now,
and the PROGN is pretty ugly. Let's separate it into two functions.

Thanks!

  Leslie
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"weblocks" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to 
[email protected]
For more options, visit this group at 
http://groups.google.com/group/weblocks?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to