Hi Mackram,
great, I already thought I'd turned you off with my comments, heh. >> * please try to keep your lines (including docstrings) roughly to 80 >> characters. > fair enough. Any other coding standards we are following? We're pretty loose about that right now. I have (and I believe Stephen has too) found it helpful for diffability/mergeability to have one symbol per line in EXPORT expressions. No other things come to my mind right now. >> * define-client-backend: not sure if this should be a DEFVAR instead >> of a DEFPARAMETER... > Well I was thinking I wanted to overwrite the same symbol name so in > case we provide some symbol say jquery by default the user would be > able to change it by simply calling define-client-backend with symbol > jquery later on while if it was DEFVAR then he is stuck with the > default setup. Let's keep it that way then. >> * build-client-backend: let's use NCONC here instead of APPEND. >> This dep stuff is in the performance-critical path. > Thanks for the tip did not know that nconc had a shorter execution > then APPEND. Of course don't forget that the original list is clobbered with NCONC. In the cases I mentioned we know that we're operating on a private list so it's alright. > (by the way any suggestions how i can profile/debug > weblocks while i am running it a service ie with hunchentoot serving > the pages) You're lucky, I just implemented that very recently. Try searching the group for "timings" and let me know if you have any questions. >> * test HCR-10 (I think): prototype isn't quoted. This test >> will fail. > I believe you were looking at not the final commit since the final > commit I uploaded had passed all the tests. No worries, I will test the whole thing after the pull anyway. > Sure I will abstract that to one function. However there are no > effects that are in the core file that we have (I think) and all > should be implemented as I understood so correct me if I am wrong. I'm not sure what you mean here. The Flash widget for example uses the Appear effect of Scriptaculous. Leslie --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "weblocks" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/weblocks?hl=en -~----------~----~----~----~------~----~------~--~---
