Thanks a lot. I installed all the tools needed and i am ready to start. I have a question: What is the typical pull request "etiquette"? Gathering a bunch of changes and then "nagging" the writers with one pull request or doing pull request every time I commit something I consider a fix or improvement?
On Mar 30, 9:08 am, Nandan Bagchee <[email protected]> wrote: > If you fork on bitbucket you can send a pull request.. BB has the details.. > > If there is a test in src/tests just verify that it passes, but this > change seems small. > > Welcome to Weblocks! > > -- nandan > > Sent from my iPad > > On 30-Mar-2011, at 1:31 AM, radisb <[email protected]> wrote: > > > > > > > > > To be honest i'd love to contribute, but since I ve never participated > > in an open source project, I maybe dont know how thinks are supposed > > to work in such a context of collaboration. For example, suppose I > > change the code in action.lisp in a copy of the source tree i ve > > downloaded. How will I know how to proceed? Are there tests that > > should pass before i proceed to send the patch? Am I required to > > provide my own test for the issue? More importantly, I dont feel I > > know the code well enough to be able to create a suitable context to > > verify the correctness of the fix. In a summary I don't know what > > typical procedure or steps to follow when I want to contribute. Is > > sending a patch sufficient? (To tell you the truth I ve never even > > created a patch but that shouldnt be that difficult :) ) And to whom > > should I send patches to? > > > On Mar 29, 8:21 pm, "Leslie P. Polzer" <[email protected]> wrote: > >> On Mar 29, 2:49 pm, radisb <[email protected]> wrote: > > >>> Sorry if this is a silly question, bit I am trying to understand the > >>> reason of the code in get-request-action-name function (src/ > >>> action.lisp), more specifically, why request-parameter is not enough? > >>> In what situation would hunchentoot:get-parameter / post-parameter > >>> (which are called by request-parameter) return nil, while > >>> hunchentoot:parameter would not? > > >> Sounds like an oversight by whoever wrote this. It's a minor > >> conundrum, patches are welcome. :) > > >> Leslie > > > -- > > You received this message because you are subscribed to the Google Groups > > "weblocks" group. > > To post to this group, send email to [email protected]. > > To unsubscribe from this group, send email to > > [email protected]. > > For more options, visit this group > > athttp://groups.google.com/group/weblocks?hl=en. -- You received this message because you are subscribed to the Google Groups "weblocks" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/weblocks?hl=en.
